Defer population of attachment parent types even further#7530
Merged
labkey-adam merged 1 commit intodevelopfrom Mar 28, 2026
Merged
Defer population of attachment parent types even further#7530labkey-adam merged 1 commit intodevelopfrom
labkey-adam merged 1 commit intodevelopfrom
Conversation
labkey-jeckels
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Upgrade tests started failing after the related PR was merged. The change to correctly detect the Structure2D attachment column in Compounds seems more sensitive to the underlying columns vs. the previous approach.
core.populateAttachmentParentTypeColumn()(which uses the data class parent type that examines the tables) runs beforeexp.addRowIdToProvisionedDataClassTables()(which alters the tables, removing ClassId). The solution is to throw the attachment parent type upgrade in aStartupListener, which runs after all@DeferredUpgrades.Also, re-run that parent type upgrade on all deployments to fix
ParentTypevalues for those Structure2D columns.And remove all previous invocations of this upgrade code; we need only one.
Related Pull Requests