Encourage optional feature flag names that work as startup props#7531
Open
labkey-adam wants to merge 1 commit intodevelopfrom
Open
Encourage optional feature flag names that work as startup props#7531labkey-adam wants to merge 1 commit intodevelopfrom
labkey-adam wants to merge 1 commit intodevelopfrom
Conversation
labkey-adam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Optional/experimental feature flags automatically get registered as startup properties, but only if their names conform to Java identifier rules because that what properties files require. We've been logging non-conforming names with the hope that this will encourage developers to use conforming names. It's not working and the logging is just noise on every startup (recently removed for production deployments, but still worthless). Now switching strategy to disallow non-conforming names while grandfathering the existing non-conforming names. (It's a pain to change existing flag names.)
Related Pull Requests