Skip to content

Add workflow storage actions #7568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-susanh wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add workflow storage actions #7568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c5144dd
Do WorkflowService.onActionComplete from updateRows
labkey-susanh Apr 7, 2026
9b714d7
New workflow action enum values
labkey-susanh Apr 7, 2026
a5ed9fa
merge from develop
labkey-susanh Apr 9, 2026
637c03f
Merge remote-tracking branch 'origin/develop' into fb_workflowStorage…
labkey-susanh Apr 9, 2026
c260de3
Merge remote-tracking branch 'origin/develop' into fb_workflowStorage…
labkey-susanh Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions api/src/org/labkey/api/query/AbstractQueryUpdateService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@
import org.labkey.api.util.URIUtil;
import org.labkey.api.view.NotFoundException;
import org.labkey.api.view.UnauthorizedException;
import org.labkey.api.workflow.WorkflowService;
import org.labkey.api.writer.VirtualFile;
import org.labkey.vfs.FileLike;
import org.springframework.web.multipart.MultipartFile;
Expand Down Expand Up @@ -896,6 +897,9 @@ public List<Map<String, Object>> updateRows(User user, Container container, List
throw errors;

addAuditEvent(user, container, QueryService.AuditAction.UPDATE, configParameters, result, oldRows, providedValues);
WorkflowService service = WorkflowService.get();
if (service != null && configParameters != null && configParameters.containsKey(WorkflowService.WorkflowConfigs.ActionId))
service.onActionComplete(container, user, (Long) configParameters.get(WorkflowService.WorkflowConfigs.ActionId));
Copy link
Copy Markdown
Contributor

@cnathe cnathe Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will likely handle some of the future cases for actions yet to be implemented as well right? basically any update rows call that passes an actionId conig param, right?

Copy link
Copy Markdown
Contributor Author

@labkey-susanh labkey-susanh Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Don't know how many there will be for updateRows (without data iterators), but we'll see.


return result;
}
Expand Down
2 changes: 1 addition & 1 deletion api/src/org/labkey/api/workflow/WorkflowService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ enum ActionType
AliquotSamples("aliquot sample type parameters", "Aliquot samples"),
PoolSamples("pooling sample type parameters", "Pooled samples"),
AddToStorage("input parameters", "Added samples to storage"),
MoveInStorage("input parameters", "Moved samples to storage"),
MoveInStorage("input parameters", "Moved samples in storage"),
CheckOut("input parameters", "Checked out samples"),
CheckIn("input parameters", "Checked in samples"),
RemoveFromStorage("sample status value", "Removed samples from storage");
Expand Down
Loading