Update to 25w36b#215
Merged
Pyrofab merged 7 commits intoLadysnake:1.21from Sep 8, 2025
MoriyaShiine:1.21
Merged
Conversation
Pyrofab
reviewed
Sep 6, 2025
Member
Pyrofab
left a comment
Pyrofab
left a comment
There was a problem hiding this comment.
Looks good to me, just need to fix the actions (I think a run of updateLicenseHeaders should do)
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.*; |
Member
There was a problem hiding this comment.
I'm partial to standardize on avoiding star imports, could you configure your formatter to avoid them in this codebase ?
Pyrofab
reviewed
Sep 7, 2025
Comment on lines
23
to
25
| with: | ||
| fetch-depth: 0 | ||
| filter: 'blob:none' |
Member
There was a problem hiding this comment.
I believe this is what broke the workflow, the license task needs a git history to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.