feat!: use string primary keys and normalise Entity/File schema#17
Open
johnf wants to merge 2 commits intofeat/schema-migration-basefrom
Open
feat!: use string primary keys and normalise Entity/File schema#17johnf wants to merge 2 commits intofeat/schema-migration-basefrom
johnf wants to merge 2 commits intofeat/schema-migration-basefrom
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
BREAKING CHANGE: Entity and File primary keys change from auto-increment integers to string-based IDs. Entity.rocrateId is renamed to Entity.id, File.fileId is renamed to File.id. File now has an entityId foreign key to Entity instead of Entity having a fileId. Redundant fields removed from File (memberOf, rootCollection, contentLicenseId). Also includes: - findFirst replaced with findUnique for primary key lookups - Promise.all for parallel count+findMany queries - Simplified transformer types (removed discriminated unions)
johnf
force-pushed
the
feat/schema-migration-base
branch
from
1a94134 to
c3301c3
Compare
johnf
force-pushed
the
feat/schema-migration-string-pks
branch
from
7d74aac to
17cae47
Compare
alvinsw
reviewed
Mar 27, 2026
| model File { | ||
| id Int @id @default(autoincrement()) | ||
| id String @id @db.VarChar(768) | ||
| entityId String @db.VarChar(768) |
Member
There was a problem hiding this comment.
We can also remove the entityId altogether because the id is already unique and corresponds one-to-one with the id of the Entity table.
alvinsw
reviewed
Mar 27, 2026
| updatedAt DateTime @updatedAt | ||
|
|
||
| meta Json? | ||
| entity Entity @relation(fields: [entityId], references: [id]) |
Member
There was a problem hiding this comment.
Suggested change
| entity Entity @relation(fields: [entityId], references: [id]) | |
| entity Entity @relation(fields: [id], references: [id]) |
Member
There was a problem hiding this comment.
Example if we get rid of the entityId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Entity.rocrateIdrenamed toEntity.id,File.fileIdrenamed toFile.identityIdFK to Entity (instead of Entity havingfileId)memberOf,rootCollection,contentLicenseId)findFirstreplaced withfindUniquefor primary key lookupsPromise.allfor parallel count+findMany queriesDepends on: #11, #12, #13, #14, #15, #16 (all merged into this branch)
Test plan
pnpm lintpassespnpm testpassespnpm generatesucceeds with new schema