Skip to content

docs(ruff): correct the E501 comment - #171

Merged
LeyckerS merged 1 commit into
LeyckerS:mainfrom
FlaggedATX:main
Aug 20, 2026
Merged

LeyckerS merged 1 commit into
LeyckerS:mainfrom
FlaggedATX:main

Conversation

@FlaggedATX

Copy link
Copy Markdown
Contributor

docs(ruff): correct the E501 comment

Description

This is a documentation change, replaces the incorrect documentation of E501 (line 10) on ruff.toml for a correct one

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would change existing behavior)
  • Documentation update
  • Refactor / code cleanup
  • Other:

Checklist

  • I have tested my changes locally
  • If this affects shared logic (extraction, download engine), I also
    applied the equivalent change to moon_cli.py
  • I have kept the single-file architecture (no package split)
  • I have not added new dependencies without justification in the PR
    description

Screenshots / logs (if applicable)

docs(ruff): correct the E501 comment

@LeyckerS LeyckerS left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified rather than read, per the house rule:

  • The diff is exactly the text #79 prescribes — one line, one file, nothing else touched.
  • The new comment is true. With this repo's config and the CI's own pin (ruff==0.16.1), a 206-character line passes ruff check without a murmur, and .github/workflows/lint.yml runs ruff check . only — ruff format appears nowhere in CI. So nothing enforces line length, which is what the line now says. The old comment pointed at line-length = 100 as if something read it; with E501 off, nothing does.
  • ruff check . on the full tree passes, matching the green ruff job here.

Merging. Thank you, @FlaggedATX — a first pull request that says something true about the file it edits is exactly the point of #79.

@LeyckerS
LeyckerS merged commit fc73f9a into LeyckerS:main Aug 20, 2026
8 checks passed
LeyckerS added a commit that referenced this pull request Aug 20, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LeyckerS added a commit that referenced this pull request Sep 9, 2026
The CLI's progress line now comes from Engine.snapshot(); the rest is
accounting, one GUI note and CI, plus the last four stale version strings.

- #154 (@breezeFur, #97) CLI progress from the engine snapshot, explicit phases
- #175 (@snowyukitty, #172) final write buffer no longer counted twice
- #169 (@yhuikzdtguioaert, #83) Extractors slider shows min(Extractors, Pages)
- #176 (@tunglambk, #174) node --check gate for web/
- #165 (@nightcityblade, #164) ruff.toml and pytest.ini watched by CI
- #168 (@StefStrg, #93) docs-cli-check watches its own file on PRs
- #170 (@harshvardhan60792, #160) regression test for the download_file stub
- #171 (@FlaggedATX, #79) honest E501 comment in ruff.toml
- #167 (@mazi-eth, #80) dead _LOG_MAX_LINES removed
- SECURITY.md, web/index.html, web/app.js, bug_report.yml: 14.x/4.0 -> 4.x/v4.2

README: new "What V4.2 is", 4.1 demoted to "was", test count 50 -> 68.
AUTHORS: @breezeFur added. Changelog: the double append predates #150.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants