Support multiple telegram recipients via TELEGRAM_CHAT_IDS#174
Closed
TaprootFreak wants to merge 1 commit intodevelopfrom
Closed
Support multiple telegram recipients via TELEGRAM_CHAT_IDS#174TaprootFreak wants to merge 1 commit intodevelopfrom
TaprootFreak wants to merge 1 commit intodevelopfrom
Conversation
Replace the single TELEGRAM_CHAT_ID env-var with a comma-separated TELEGRAM_CHAT_IDS list. sendMessage iterates over every recipient; per-recipient failures are logged and skipped so a single bad chat-id does not suppress the entire alert. Returns true iff at least one delivery succeeded. Aligns LDS with the same multi-recipient pattern used by the d-EURO and JuiceDollar monitoring stacks plus DFXswiss/rangekeeper, so an op-team gets multi-recipient delivery via comma-separated env-var without needing self-service /subscribe complexity.
Contributor
Author
|
Superseded by /subscribe self-service pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the single
TELEGRAM_CHAT_IDenv-var with a comma-separatedTELEGRAM_CHAT_IDSlist.sendMessageiterates over every recipient; per-recipient failures are logged and skipped so a single bad chat-id (e.g. user blocked the bot) does not suppress the entire alert.sendMessagereturnstrueiff at least one delivery succeeded.Usage
Why
Aligns LDS with the same multi-recipient pattern used by the d-EURO and JuiceDollar monitoring stacks plus DFXswiss/rangekeeper. Op-team gets multi-recipient delivery via a single env-var; no self-service
/subscribepolling complexity needed for a small static team.Migration
Azure App Service config needs
TELEGRAM_CHAT_IDSset. Existing single chat-id flows through unchanged when it's the only entry.TELEGRAM_CHAT_IDenv is no longer read.Test plan
npm run buildclean