chore: simplify lightprograminterface trait

[SwenSchaeferjohann]

---

[devin-ai-integration]

Devin Review found 1 potential issue.

View 5 additional findings in Devin Review.

[devin-ai-integration]

🟡 SwapSdk::new panics on short input data instead of returning an error

The SwapSdk::new constructor at pinocchio/swap/tests/sdk.rs:52 does pool_data[8..] without checking that pool_data has at least 8 bytes. If pool_data.len() < 8, this will panic with an index-out-of-bounds error instead of returning Err(SwapSdkError::ParseError(...)).

Root Cause

The old code (parse_pool_state) had an explicit bounds check:

if data.len() < 8 {
    return Err(SwapSdkError::ParseError("Account data too short".to_string()));
}

The new code removed this check and directly indexes into the slice:

let pool = PoolState::deserialize(&mut &pool_data[8..])

Since the function returns Result<Self, SwapSdkError>, callers expect errors to be returned gracefully, not as panics. The same issue exists in load_specs at line 135 (account.data()[8..]) where short pool state data would also cause a panic.

Impact: Any caller passing data shorter than 8 bytes will get an unrecoverable panic instead of a handleable error. While this is test SDK code, it's still a regression in error handling robustness.

Suggested change

	let pool = PoolState::deserialize(&mut &pool_data[8..])
	if pool_data.len() < 8 {
	return Err(SwapSdkError::ParseError("Account data too short".to_string()));
	}
	let pool = PoolState::deserialize(&mut &pool_data[8..])

---

Was this helpful? React with 👍 or 👎 to provide feedback.