fix(cache): invalidate link resolution cache on update and delete#20
Open
RaoUsama7 wants to merge 1 commit intoLinkForty:mainfrom
Open
fix(cache): invalidate link resolution cache on update and delete#20RaoUsama7 wants to merge 1 commit intoLinkForty:mainfrom
RaoUsama7 wants to merge 1 commit intoLinkForty:mainfrom
Conversation
- Add reusable helper for Redis link-resolution cache invalidation - Invalidate cached keys after successful link update and delete - Clear both old and new key sets when template association changes - Add unit tests for cache invalidation helper behavior
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix stale redirect and SDK resolve behavior by invalidating Redis link-resolution cache entries when links are updated or deleted.
Previously, the read path cached link JSON for 5 minutes, but link mutation routes did not invalidate those keys. This meant stale redirects or stale SDK resolutions could be served until TTL expiry.
This change adds a small reusable cache invalidation helper and applies it to link update/delete flows.
Type of Change
Changes Made
invalidateLinkResolutionCachehelper for Redis link-resolution cache keysNotes
Testing