fix(cache): invalidate link resolution cache on update and delete#21
Open
RaoUsama7 wants to merge 1 commit intoLinkForty:mainfrom
Open
fix(cache): invalidate link resolution cache on update and delete#21RaoUsama7 wants to merge 1 commit intoLinkForty:mainfrom
RaoUsama7 wants to merge 1 commit intoLinkForty:mainfrom
Conversation
- Add reusable helper for Redis link-resolution cache invalidation - Invalidate cached keys after successful link update and delete - Clear both old and new key sets when template association changes - Add unit tests for cache invalidation helper behavior
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small follow-up fix based on prior review feedback.
This change improves type safety in the client IP helper and corrects missing-IP fallback behavior so installs without an IP do not accidentally match on the IP fingerprint factor.
Changes Made
(request as any).socket?.remoteAddresswithrequest.raw.socket?.remoteAddress'unknown'fallback with empty string''Why this matters
Using
'unknown'as a fallback is truthy and could allow two no-IP installs to match on the IP component of fingerprint scoring.Returning
''instead ensures the IP comparison is skipped when no trusted IP is available.Testing