Skip to content

test(release_homebrew): Enable repo cleanup in homebrew_core_fork_repo fixture #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

test(release_homebrew): Enable repo cleanup in homebrew_core_fork_repo fixture #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/release_homebrew/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
pytest.skip("Skipping, cannot be tested on Windows")


@pytest.fixture(scope='function') # todo: fix repo deletion
@pytest.fixture(scope='function')
def homebrew_core_fork_repo():
directory = os.path.join(os.environ['GITHUB_WORKSPACE'], 'release_homebrew_action')
os.makedirs(directory, exist_ok=True)
Expand Down Expand Up @@ -91,8 +91,8 @@

yield repo_directory

# remove the homebrew-core fork (this fails)
# shutil.rmtree(repo_directory)
# remove the homebrew-core fork
shutil.rmtree(repo_directory)


@pytest.fixture(scope='function')
Expand All @@ -104,7 +104,7 @@
)
if proc.returncode != 0:
print(proc.stderr.decode('utf-8'))
raise RuntimeError('Failed to uninstall hello_world formula')

Check failure on line 107 in tests/release_homebrew/conftest.py

View workflow job for this annotation

GitHub Actions / tests (macos-latest) 

Failed to uninstall hello_world formula

Check failure on line 107 in tests/release_homebrew/conftest.py

View workflow job for this annotation

GitHub Actions / tests (macos-latest) 

Failed to uninstall hello_world formula

Check failure on line 107 in tests/release_homebrew/conftest.py

View workflow job for this annotation

GitHub Actions / tests (ubuntu-latest) 

Failed to uninstall hello_world formula

Check failure on line 107 in tests/release_homebrew/conftest.py

View workflow job for this annotation

GitHub Actions / tests (ubuntu-latest) 

Failed to uninstall hello_world formula

# untap the temporary repo
proc = subprocess.run(
Expand Down
Loading