Open
Conversation
stepancar
commented
Sep 19, 2025
| } | ||
| REJECT_STATUS; | ||
|
|
||
| c->status = napi_create_external_buffer(env, c->readLen, c->readBuf, readFinalizer, (void*)(uint64_t)c->readLen, &result); |
Author
There was a problem hiding this comment.
Please, DONT LOOK AT THIS CHANGE
stepancar
commented
Sep 19, 2025
| status = napi_get_null(env, &result); | ||
| } else { | ||
| hintRef = av_buffer_ref(p->packet->buf); | ||
| status = napi_create_external_buffer(env, hintRef->size, hintRef->data, |
Author
There was a problem hiding this comment.
Please, DONT LOOK AT THIS CHANGE
sabjorn
reviewed
Sep 19, 2025
| status = napi_create_external_buffer(env, size, data, frameBufferFinalizer, ref, &element); | ||
| // For other planar formats, adjust with chroma subsampling if needed | ||
| else if (desc->log2_chroma_h && x > 0) { | ||
| plane_h = (frame->height + (1 << desc->log2_chroma_h) - 1) >> desc->log2_chroma_h; |
sabjorn
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently beamcoder crashes when we try to access frame.data for videos with YUVA format.
Didn't really noticed this issue because we use filter https://github.com/Lumen5/framefusion/blob/main/src/backends/beamcoder.ts#L95
This filter helps because it always makes buffers squential
This requires additional time on CPU. This happens always even if input pixel format is equa output pixel format.
Ideally, we don't need to use those filters. we could get raw pixels data instead.
Lumen5/framefusion#73
https://github.com/Lumen5/luminary/pull/7748