luxmark: hide compilation dialog on errors like CL_OUT_OF_HOST_MEMORY#15
Open
illwieckz wants to merge 1 commit intoLuxCoreRender:masterfrom
Open
luxmark: hide compilation dialog on errors like CL_OUT_OF_HOST_MEMORY#15illwieckz wants to merge 1 commit intoLuxCoreRender:masterfrom
illwieckz wants to merge 1 commit intoLuxCoreRender:masterfrom
Conversation
The compilation dialog should be hidden if the OpenCL kernel compilation failed, and not let the application in an unusable state with all inputs disabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compilation dialog should be hidden if the OpenCL kernel compilation failed, and not let the application in an unusable state with all inputs disabled.
This makes sure the application remains in an usable state when OpenCL compilation fails with errors like that:
This work is courtesy of I ♥ Compute initiative funded by 🇫🇷️ rebatir.fr.