chore(mst/ist) Refactor isotherm #2626
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se it in the sorption method
…ew classes. Refactor the IST package to use the new isotherm classes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Isotherms in the MST and IST packages
It doesn't contain any functional changes,
The 3 isotherms are moved to their own files and they all implement the IsothermType interface.
A Isotherm factory and Isotherm enum module is added as well
By making these changes a lot of if-else and select case blocks of logic can be simplified.
The main reason for this PR is to prepare the code base for the next PR in which a new formulation for the sorption term in the mst package will be added
I cleaned up most of the code related to the isotherm. However there are 2 areas that need more attention but which i consider out of scope: