Skip to content

Fix: make entire sidebar button clickable (#445) #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2025
Merged

Fix: make entire sidebar button clickable (#445) #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04514d2
Fix: make entire sidebar button clickable
msinha569 Oct 30, 2025
1cee0bc
chore: fix import order as per Biome rules and removed nested links t…
msinha569 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions surfsense_web/components/sidebar/app-sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
"use client";

import Link from "next/link";
import Image from "next/image";

import {
AlertCircle,
BookOpen,
Expand Down Expand Up @@ -33,6 +36,7 @@ import {
SidebarMenuItem,
} from "@/components/ui/sidebar";


// Map of icon names to their components
export const iconMap: Record<string, LucideIcon> = {
BookOpen,
Expand Down Expand Up @@ -213,16 +217,22 @@ export const AppSidebar = memo(function AppSidebar({
<SidebarHeader>
<SidebarMenu>
<SidebarMenuItem>
<SidebarMenuButton size="lg" asChild aria-label="Go to home page">
<div>
<div className="bg-sidebar-primary text-sidebar-primary-foreground flex aspect-square size-8 items-center justify-center rounded-lg">
<Logo className="rounded-lg" />
</div>
<div className="grid flex-1 text-left text-sm leading-tight">
<span className="truncate font-medium">SurfSense</span>
<span className="truncate text-xs">beta v0.0.8</span>
</div>
<SidebarMenuButton asChild size="lg">
<Link href="/" className="flex items-center gap-2 w-full">
<div className="bg-sidebar-primary text-sidebar-primary-foreground flex aspect-square size-8 items-center justify-center rounded-lg">
<Image
src="/icon-128.png"
alt="SurfSense logo"
width={32}
height={32}
className="rounded-lg"
/>
</div>
<div className="grid flex-1 text-left text-sm leading-tight">
<span className="truncate font-medium">SurfSense</span>
<span className="truncate text-xs">beta v0.0.8</span>
</div>
</Link>
</SidebarMenuButton>
</SidebarMenuItem>
</SidebarMenu>
Expand Down
Loading