Skip to content

Add passive mode touch events, calms Lighthouse#295

Closed
inoas wants to merge 2 commits into
Mango:masterfrom
inoas:patch-1
Closed

Add passive mode touch events, calms Lighthouse#295
inoas wants to merge 2 commits into
Mango:masterfrom
inoas:patch-1

Conversation

@inoas

@inoas inoas commented Apr 10, 2020

Copy link
Copy Markdown

Refs:
#291
#289
#267

@coveralls

coveralls commented Apr 10, 2020

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 69.88% when pulling 90c433d on inoas:patch-1 into 6eb8440 on Mango:master.

@inoas

inoas commented Apr 10, 2020

Copy link
Copy Markdown
Author

I am using npm install --save inoas/slideout#patch-1 until this gets merged.

Edit: Somehow npm/node didnt eat the above thing correctly. This works in package.json "slideout": "git://github.com/inoas/slideout.git#patch-1",

Note: You should use your own fork of my fork to be on the safe side, if you go the same route

@inoas

inoas commented Apr 10, 2020

Copy link
Copy Markdown
Author

@pazguille any chance to merge this rather soon?

@inoas

inoas commented Apr 10, 2020

Copy link
Copy Markdown
Author

I ran tests, hints, fixed a preexisting CS issue, ran build - now it should be ok.

@inoas

inoas commented Apr 13, 2020

Copy link
Copy Markdown
Author

@pazguille Do you still in any way maintain this, at least eventually consider some PRs to merge?
That would be so kind.

@inoas

inoas commented Apr 20, 2020

Copy link
Copy Markdown
Author

Ping @pazguille - hope!

@htstudios

Copy link
Copy Markdown

Any news?

@paskal

paskal commented Dec 29, 2023

Copy link
Copy Markdown

@pazguille gentle ping for review and merge.

@inoas

inoas commented May 8, 2024

Copy link
Copy Markdown
Author

kinda dead.

@inoas inoas closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants