Result#generate_print_pdf refactor#7964
Conversation
…tem tmp directory instead of the project tmp directory
Coverage Report for CI Build 26587162459Coverage remained the same at 90.277%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
| contents = sf.retrieve_file(repo: repo) | ||
| tmp_path = File.join(workdir, 'tmp_file.pdf') | ||
| FileUtils.rm_rf(tmp_path) | ||
|
|
There was a problem hiding this comment.
Delete this blank line
| combined_pdf >> CombinePDF.load("#{workdir}/front.pdf") | ||
| combined_pdf | ||
| end | ||
|
|
There was a problem hiding this comment.
Keep one blank line here
There was a problem hiding this comment.
Just to clarify, do you want me to insert a blank line after line 418 (combined_pdf) or before line 418?
There was a problem hiding this comment.
The diff is showing that in the version on master, Line 418 was a blank line. This immediately followed the end on Line 417.
In the changed version, the end is now on Line 419. You should insert a blank line after this end.
The diff is indicating that you deleted this line, perhaps without realizing it; so my comment here falls under the category of "revert changes that are unnecessary".
| - Fixed `(hidden)` assignment labeling for assignments with `visible_on` and/or `visible_until` set (#7944) | ||
|
|
||
| ### 🔧 Internal changes | ||
| - Refactored `Result#generate_print_pdf` to use Dir.mktmpdir instead of Fileutils.mkdir_p (#7964) |
There was a problem hiding this comment.
In general, use monospace code font for method names (and other names which are from code)
3 participants
Proposed Changes
Refactored Result#generate_print_pdf to use Dir.mktmpdir instead of Fileutils.mkdir_p
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)