update intracellular in first time step#364
Open
drbergman wants to merge 1 commit intoMathCancer:developmentfrom
Open
update intracellular in first time step#364drbergman wants to merge 1 commit intoMathCancer:developmentfrom
drbergman wants to merge 1 commit intoMathCancer:developmentfrom
Conversation
- this change allows intracellular updates to occur in the first diffusion step - before, they had to wait one diffusion step to update (I don't see a reason why) - removed need for `initialzed` [sic] field in `Cell_Container` class - also make easier-to-parse logic and variable names for when to update phenotype and mechanics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low priority PR that fixes bug causing intracellular updates to skip the first diffusion time step at t=0. I don't believe that PhysiBoSS or PhysiCelldFBA require this step to be skipped, but please inform if it is necessary :)
It is possible that rules that depend on variables expected to be set in a
post_intracellular_updatefunction could receive unexpected inputs causing unintended behavior in the firstadvance_bundled_phenotype_functionsand subsequent mechanics updates.initialzed[sic] field inCell_Containerclass