when asym divs probs sum to >1, exit with msg#367
Open
drbergman wants to merge 1 commit intoMathCancer:developmentfrom
Open
when asym divs probs sum to >1, exit with msg#367drbergman wants to merge 1 commit intoMathCancer:developmentfrom
drbergman wants to merge 1 commit intoMathCancer:developmentfrom
Conversation
previously, used `throw` but the standard `main.cpp` catches the exception and still exits with 0
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
core/PhysiCell_standard_models.cpp:1385
- The use of 'pCD_parent' appears to be incorrect as the function parameters use 'pCell_parent'. This likely introduces a bug if 'pCD_parent' is not properly defined.
std::cerr << "Error: Asymmetric division probabilities for " + pCD_parent->name + " sum to greater than 1.0 and cannot be normalized." << std::endl;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@heberlr first identified this behavior and a discussion led to opening #347. While better handling of thrown exceptions would be an improvement, for now have this error behave like all others and
exit(-1).previously, used
throwbut the standardmain.cppcatches the exception and still exits with 0