hotfix finding copying input files to output#371
Open
drbergman wants to merge 1 commit intoMathCancer:masterfrom
Open
hotfix finding copying input files to output#371drbergman wants to merge 1 commit intoMathCancer:masterfrom
drbergman wants to merge 1 commit intoMathCancer:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This hotfix ensures that files are correctly copied to the output folder regardless of whether the path separator is Linux/MacOS ('/') or Windows ('\').
- Updated file basenames extraction to support both '/' and '\'
- Improves cross-platform file path handling for file copying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had only looked for the Linux/MacOS pathsep (
'/') to identify the basename for the file being copied to the output folder. If a user set this with a Windows path, it would lead to the file not being copied.