chore(skills): the tree's extension surfaces ship empty - #240
Open
Max17190 wants to merge 4 commits into
Open
Conversation
A file under .agents/ or .openmax/ is installed capability every session in this repo pays for on every request, not an example. The delegate and parallel-explore skills predate that principle (they landed the day #37 removed the built-in task subagent, as its replacement) and survived #222's plan-mode removal as a grandfathered exception, at a measured 530 chars (~132 tokens) of frozen prompt per request. The surfaces now ship empty, the AGENTS example says to ask the agent for a delegate skill, and a guard test reads the repository index so a tracked file can never quietly return.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A file under
.agents/or.openmax/is installed capability that every session working in this repo pays frozen-prompt bytes for on every request, not an example. That principle removed the shipped plan mode in #222, but thedelegateandparallel-exploreskills predate it: they landed the same day #37 removed the built-in task subagent, as its replacement, and survived as a grandfathered exception. Measured withopenmax --spec usage, they cost 530 chars (~132 tokens) of frozen prefix per request in this repo.Summary
.agents/skills/(the recipes are retained outside the repo with the measurement rigs).AGENTS.example.md's nested-agents row now says to ask the agent to author a delegate skill when the project wants one, instead of naming pre-installed files.the_extension_surfaces_ship_empty(prompt.rs) reads the repository index viagit ls-filesand fails when any tracked file returns to either surface; it skips only when git or a checkout is absent (a packaged crate), and fails on any other read problem.Test Plan
cargo test --workspace: 842 passed, 0 failed.cargo clippy --workspace --all-targets: zero warnings.Greptile Summary
The repository now recognizes packaged source trees by the absence of
.gitmetadata rather than parsing Git’s localized error text. The extension-surface guard skips correctly in a source-tree copy, passes in this checkout, and rejects a tracked file placed under a protected extension directory.Merge-safe: yes.
Confidence Score: 5/5
No blocking failure remains.
The packaged-tree behavior was exercised under a non-English locale and no longer depends on Git diagnostic text; the repository guard also accepted the current checkout and rejected a controlled tracked extension file.
What T-Rex did
Reviews (3): Last reviewed commit: "fix(core): the packaged-tree skip is str..." | Re-trigger Greptile