feat: Providing tests for ComposeDown

[oxisto]

This PR adds a dynamic tests for ComposeDown and incorporates the fix of #39 to correctly handle container_name.

[Mcrich23]

This looks great! Thank you so much. Going to do a quick code review right now.

[Mcrich23]

After taking a deeper look, it mostly feels good, but I have some specific requests regarding tests to make sure our tests are robust and strong to bring into the future of Container-Compose.

[Mcrich23]

Could you please make this check that all of these containers are running instead of just the first one?

[oxisto]

adjusted it, but somehow this fails on my machine now, since it can't start the Wordpress container, but that might be a different bug :(

[Mcrich23]

Interesting. Try manually restarting the container subsystem

[Mcrich23]

@oxisto I made a couple testing expect changes to be more dynamic. When running tests though, it seems that wordpress is receiving an invalid argument.

container logs Container-Compose_Tests_00C176C4-234A-4D2A-A2A9-BD33F943F99B-wordpress
Error: internalError: " Error Domain=NSPOSIXErrorDomain Code=22 "Invalid argument""

But it still works on main's tests, meaning that wordpress didn't change something. Can you please take a look at your tests?

[oxisto]

@oxisto I made a couple testing expect changes to be more dynamic. When running tests though, it seems that wordpress is receiving an invalid argument.

container logs Container-Compose_Tests_00C176C4-234A-4D2A-A2A9-BD33F943F99B-wordpress
Error: internalError: " Error Domain=NSPOSIXErrorDomain Code=22 "Invalid argument""

But it still works on main's tests, meaning that wordpress didn't change something. Can you please take a look at your tests?

Thanks! Yeah it's weird, it seems either web or Wordpress is not be able to start but it basically uses the same code as in the "up" test. The only thing I changed is that I extracted the "run" into a utility function and maybe this utility function is doing slightly different things, I'll take a look.

[oxisto]

@oxisto I made a couple testing expect changes to be more dynamic. When running tests though, it seems that wordpress is receiving an invalid argument.

container logs Container-Compose_Tests_00C176C4-234A-4D2A-A2A9-BD33F943F99B-wordpress
Error: internalError: " Error Domain=NSPOSIXErrorDomain Code=22 "Invalid argument""

But it still works on main's tests, meaning that wordpress didn't change something. Can you please take a look at your tests?

FYI the wordpress test-case also "fails" on the "up" tests, the wordpress container is not starting correctly because it can no connect other the DB. you can see that on the test logs

Error Domain=ContainerWait Code=1 "Timed out waiting for container 'Container-Compose_Tests_927D9EC3-DAE9-40F4-94B5-DAE69BB4E95F-wordpress' to be running." UserInfo={NSLocalizedDescription=Timed out waiting for container 'Container-Compose_Tests_927D9EC3-DAE9-40F4-94B5-DAE69BB4E95F-wordpress' to be running.}

but the test is actually not asserting that it is running.

[oxisto]

getIPForRunningService is returning the wrong IP address, it returns the address of the gateway, but it should return the address of the container

[Mcrich23]

but the test is actually not asserting that it is running.

how so? It checks that all containers have the running status.

[oxisto]

but the test is actually not asserting that it is running.

how so? It checks that all containers have the running status.

No it does not :) Check testWordPressCompose(), that does NOT check the running status. TestComplexDependencyChain() DOES.

The Wordpress container has several problems and should probably not be used. It tries to copy data into the volume, which fails horribly on named containers because of path issues and it fails even on non-named containers because of permission problems.

[Mcrich23]

Ah yes, you are correct about that check. Thats a bad test

[Mcrich23]

I am going to merge this and then we can replace wordpress as a separate pr.