-
Notifications
You must be signed in to change notification settings - Fork 11
add project workflow #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
james-bruten-mo
wants to merge
5
commits into
MetOffice:main
Choose a base branch
from
james-bruten-mo:add_project_workflow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+87
−16
Open
add project workflow #160
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ea4ba5f
add project workflow
james-bruten-mo 0ea1801
Merge branch 'main' into add_project_workflow
james-bruten-mo 4a84d5a
add permissions
james-bruten-mo 52c991a
Merge branch 'add_project_workflow' of github.com:james-bruten-mo/Sim…
james-bruten-mo ea9e7e6
Merge branch 'main' into add_project_workflow
james-bruten-mo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,69 @@ | ||
| # Description | ||
| # PR Summary | ||
|
|
||
| ## Summary | ||
| Sci/Tech Reviewer: <!-- SR id, filled by author when ready for review (e.g. @octocat) --> | ||
| Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) --> | ||
|
|
||
| _Briefly describe the feature being introduced._ | ||
| <!-- To be completed by the developer --> | ||
|
|
||
| ## Changes | ||
| <!-- Provide a brief description of the changes in this PR, including any notes | ||
| useful for reviewers --> | ||
|
|
||
| _List the major changes made in this pull request._ | ||
| <!-- List any linked PRs here | ||
| - linked MetOffice/<REPO-NAME>#<pr-number> | ||
| --> | ||
|
|
||
| ## Dependency | ||
| <!-- List any blocking PRs or issues to be closed here | ||
| - is blocked-by #pr-number | ||
| - blocks #pr-number | ||
| - closes #issue-number (auto-closes the issue) | ||
| - fixes #issue-number (auto-closes the issue) | ||
| - is related to #issue-number | ||
| --> | ||
|
|
||
| _List dependent changes. Can use build-group logic here._ | ||
| ## Code Quality Checklist | ||
|
|
||
| ## Impact | ||
| - [ ] I have performed a self-review of my own code | ||
| - [ ] My code follows the project's [style guidelines](https://metoffice.github.io/lfric_core/how_to_contribute/index.html#how-to-contribute-index) | ||
| - [ ] Comments have been included that aid understanding and enhance the readability of the code | ||
| - [ ] My changes generate no new warnings | ||
| - [ ] All automated checks in the CI pipeline have completed successfully | ||
|
|
||
| _Discuss any potential impacts this feature may have on existing functionalities._ | ||
| ## Testing | ||
|
|
||
| ## Issues addressed | ||
| - [ ] This change has been tested appropriately (please describe) | ||
|
|
||
| Resolves | ||
| ## Security Considerations | ||
|
|
||
| _List issue(s) related to this PR._ | ||
| - [ ] I have reviewed my changes for potential security issues | ||
| - [ ] Sensitive data is properly handled (if applicable) | ||
| - [ ] Authentication and authorisation are properly implemented (if applicable) | ||
|
|
||
| ## Coordinated merge | ||
| ## AI Assistance and Attribution | ||
|
|
||
| _Specify any coordinated merges here._ | ||
| - [ ] Some of the content of this change has been produced with the assistance of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) (including attribution labels) | ||
|
|
||
| <!-- If AI has been used, please provide more details here --> | ||
|
|
||
| ## Checklist | ||
| # Sci/Tech Review | ||
|
|
||
| <!-- To be completed by the Sci/Tech Reviewer --> | ||
| <!-- May be skipped for trivial tickets --> | ||
|
|
||
| - [ ] I understand this area of code and the changes being added | ||
| - [ ] The proposed changes correspond to the pull request description | ||
| - [ ] Documentation is sufficient (do documentation papers need updating) | ||
| - [ ] Sufficient testing has been completed | ||
|
|
||
| (_Please alert the code reviewer via a tag when you have approved the SR_) | ||
|
|
||
| # Code Review | ||
|
|
||
| <!-- To be completed by the Code Reviewer --> | ||
|
|
||
| - [ ] All dependencies have been resolved | ||
| - [ ] Related Issues have been properly linked and addressed | ||
| - [ ] Code quality standards have been met | ||
| - [ ] Tests are adequate and have passed | ||
| - [ ] Security considerations have been addressed | ||
| - [ ] Performance impact is acceptable | ||
|
|
||
| - [ ] I have performed a self-review of my own changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Track Review Project | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: [Trigger Review Project] | ||
| types: | ||
| - completed | ||
|
|
||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| track_review_project: | ||
| uses: MetOffice/growss/.github/workflows/track-review-project.yaml@main | ||
| secrets: inherit | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| name: Trigger Review Project | ||
|
|
||
| on: | ||
| pull_request_target: | ||
| types: ["opened", "synchronize", "reopened", "edited", "review_requested", "review_request_removed"] | ||
| pull_request_review: | ||
| pull_request_review_comment: | ||
|
|
||
yaswant marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| permissions: | ||
| actions: read | ||
| contents: read | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| trigger_project_workflow: | ||
| uses: MetOffice/growss/.github/workflows/trigger-project-workflow.yaml@main | ||
| secrets: inherit | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.