Skip to content

feat: add asset picker opened and selected metrics #7575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghgoodreau wants to merge 6 commits into
base: main
Choose a base branch
from
+19 −0
Open

feat: add asset picker opened and selected metrics #7575

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94ae82f
feat: add asset picker opened and selected metrics
ghgoodreau Jan 7, 2026
3667333
fix: lint
ghgoodreau Jan 20, 2026
605d1a0
fix: eslint suppressions update
ghgoodreau Jan 29, 2026
e35be7a
Merge branch 'main' into feat/add-asset-picker-metrics
ghgoodreau Feb 10, 2026
74b315a
chore: lint
ghgoodreau Feb 10, 2026
722aa4c
changelog
ghgoodreau Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/bridge-controller/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `AssetPickerOpened` and `AssetSelected` unified swap bridge metrics events. ([#7575](https://github.com/MetaMask/core/pull/7575))

### Changed

- Bump `@metamask/keyring-api` from `^21.0.0` to `^21.5.0` ([#7857](https://github.com/MetaMask/core/pull/7857))
Expand Down
2 changes: 2 additions & 0 deletions packages/bridge-controller/src/bridge-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,6 +956,8 @@ export class BridgeController extends StaticIntervalPollingController<BridgePoll
};
}
case UnifiedSwapBridgeEventName.AssetDetailTooltipClicked:
case UnifiedSwapBridgeEventName.AssetPickerOpened:
case UnifiedSwapBridgeEventName.AssetSelected:
return baseProperties;
// These events may be published after the bridge-controller state is reset
// So the BridgeStatusController populates all the properties
Expand Down
2 changes: 2 additions & 0 deletions packages/bridge-controller/src/utils/metrics/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ export enum UnifiedSwapBridgeEventName {
AssetDetailTooltipClicked = `${UNIFIED_SWAP_BRIDGE_EVENT_CATEGORY} Asset Detail Tooltip Clicked`,
QuotesValidationFailed = `${UNIFIED_SWAP_BRIDGE_EVENT_CATEGORY} Quotes Failed Validation`,
StatusValidationFailed = `${UNIFIED_SWAP_BRIDGE_EVENT_CATEGORY} Status Failed Validation`,
AssetPickerOpened = `${UNIFIED_SWAP_BRIDGE_EVENT_CATEGORY} Asset Picker Opened`,
AssetSelected = `${UNIFIED_SWAP_BRIDGE_EVENT_CATEGORY} Asset Selected`,
PollingStatusUpdated = `${UNIFIED_SWAP_BRIDGE_EVENT_CATEGORY} Polling Status Updated`,
}

Expand Down
11 changes: 11 additions & 0 deletions packages/bridge-controller/src/utils/metrics/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,15 @@ export type RequiredEventContextFromClient = {
[UnifiedSwapBridgeEventName.StatusValidationFailed]: {
failures: string[];
};
[UnifiedSwapBridgeEventName.AssetPickerOpened]: {
location: 'source' | 'destination';
};
[UnifiedSwapBridgeEventName.AssetSelected]: {
token_symbol: string;
token_address: string | null;
chain_id: CaipChainId | null;
location: 'source' | 'destination';
};
[UnifiedSwapBridgeEventName.PollingStatusUpdated]: TradeData &
Pick<QuoteFetchData, 'price_impact'> &
Omit<RequestMetadata, 'security_warnings'> &
Expand Down Expand Up @@ -284,6 +293,8 @@ export type EventPropertiesFromControllerState = {
[UnifiedSwapBridgeEventName.StatusValidationFailed]: RequestParams & {
refresh_count: number;
};
[UnifiedSwapBridgeEventName.AssetPickerOpened]: null;
[UnifiedSwapBridgeEventName.AssetSelected]: null;
[UnifiedSwapBridgeEventName.PollingStatusUpdated]: null;
};

Expand Down
Loading