Skip to content

chore: make react-dom and react-native optional peer dependencies #9295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gudahtt wants to merge 3 commits into
base: main
Choose a base branch
from
+18 −0
Open

chore: make react-dom and react-native optional peer dependencies #9295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
670a560
chore: make `react-dom` and `react-native` optional peer dependencies
Gudahtt Jun 27, 2026
5fc10a2
Update changelog
Gudahtt Jun 27, 2026
5e323b3
Silence knip false positive
Gudahtt Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions knip.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ const config: KnipConfig = {
// relative path that doesn't resolve inside this monorepo.
ignoreUnresolved: [/^\.\.\/\.\.\/\.\.\/core\/Engine$/u],
},
'packages/react-data-query': {
// Flagged due to knip bug, see https://github.com/webpro-nl/knip/issues/1823
ignoreDependencies: ['react-dom', 'react-native'],
},

// -- Per-workspace `ignoreDependencies` snapshots --
//
Expand Down
1 change: 1 addition & 0 deletions packages/react-data-query/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Bump `@metamask/utils` from `^11.9.0` to `^11.11.0` ([#9074](https://github.com/MetaMask/core/pull/9074))
- Make `react-dom` and `react-native` peer dependencies optional ([#9295](https://github.com/MetaMask/core/pull/9295))

## [0.2.1]

Expand Down
8 changes: 8 additions & 0 deletions packages/react-data-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@
"react-dom": "^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0",
"react-native": "*"
},
"peerDependenciesMeta": {
"react-dom": {
"optional": true
},
"react-native": {
"optional": true
}
},
"engines": {
"node": "^18.18 || >=20"
}
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8181,6 +8181,11 @@ __metadata:
react: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
react-dom: ^16.8.0 || ^17.0.0 || ^18.0.0 || ^19.0.0
react-native: "*"
peerDependenciesMeta:
react-dom:
optional: true
react-native:
optional: true
languageName: unknown
linkType: soft

Expand Down
Loading