chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo#24930
Merged
chore: update Yarn to 4.2.2 and remove yarn-*.cjs from the repo#24930
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
reviewed
May 31, 2024
.circleci/config.yml
Outdated
Contributor
There was a problem hiding this comment.
Does it with with just corepack enable sans sudo?
Contributor
Author
There was a problem hiding this comment.
Nope, this is what happens without sudo https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/84179/workflows/a00c10d8-5c25-4604-9332-5a71d51e512f/jobs/3025527
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24930 +/- ##
========================================
Coverage 65.79% 65.79%
========================================
Files 1364 1364
Lines 54315 54315
Branches 14126 14126
========================================
Hits 35732 35732
Misses 18583 18583 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [e8bc321]
Page Load Metrics (660 ± 484 ms)
Bundle size diffs
|
legobeat
previously approved these changes
May 31, 2024
legobeat
previously approved these changes
May 31, 2024
mcmire
approved these changes
May 31, 2024
Collaborator
Builds ready [176984d]
Page Load Metrics (107 ± 123 ms)
|
Collaborator
Builds ready [39fd66a]
Page Load Metrics (232 ± 256 ms)
|
legobeat
approved these changes
May 31, 2024
Contributor
|
@HowardBraham This broke some GitHub Actions workflows.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
yarn-*.cjsfiles from our repo (see this discussion about how these 2.6MB files shouldn't be committed)corepack enablein CircleCIThis is very similar to MetaMask/metamask-module-template#243
Related issues
Similar: MetaMask/metamask-module-template#243
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist