Skip to content

refactor: update references after renaming connect-monorepo to metamask-connect#28906

Open
ffmcgee725 wants to merge 3 commits into
mainfrom
jc/WAPI-1255
Open

refactor: update references after renaming connect-monorepo to metamask-connect#28906
ffmcgee725 wants to merge 3 commits into
mainfrom
jc/WAPI-1255

Conversation

@ffmcgee725

@ffmcgee725 ffmcgee725 commented Apr 16, 2026

Copy link
Copy Markdown
Member

Description

Updates all references from MetaMask/connect-monorepo to MetaMask/metamask-connect ahead of the GitHub repo rename.

Motivation

The connect-monorepo GitHub repo is being renamed to metamask-connect to match the external product name. While GitHub auto-redirects old URLs, redirects break if a new repo is ever created with the old name. This PR proactively updates all references.

Changes

File Occurrences What changed
scripts/fetch-rn-playground-apk.sh 3 REPO="MetaMask/connect-monorepo" variable (used for GitHub API calls to fetch the playground APK), plus header comments
tests/performance/mm-connect/utils.js 5 Sibling directory path (../metamask-connect/...), error message instructions, and comments
tests/performance/mm-connect/README.md 15 Documentation: directory layout examples, build instruction paths, GitHub URLs, CI variable descriptions
tests/performance/README.md 3 GitHub URL links to the React Native Playground

Not changed:

  • attribution.txt — contains walletconnect/walletconnect-monorepo references (different project)

Changelog

CHANGELOG entry: null

Related issues

Manual testing steps

  1. Run ./scripts/fetch-rn-playground-apk.sh — verify it resolves the GitHub Release from MetaMask/metamask-connect (will work once the repo is renamed; until then, the old URL auto-redirects)
  2. Verify grep -r 'connect-monorepo' tests/ scripts/ returns only walletconnect-monorepo hits (in attribution.txt)

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Documentation and test-helper path/API repo strings only; no wallet or production runtime behavior changes.

Overview
Renames the React Native Playground dependency from connect-monorepo to metamask-connect across performance-test docs, APK fetch tooling, and path resolution so setup matches the upcoming GitHub repo rename.

fetch-rn-playground-apk.sh now pulls release assets from MetaMask/metamask-connect. tests/performance/mm-connect/utils.ts looks for a locally built APK under ../metamask-connect/... and updates the “APK not found” instructions accordingly. tests/performance/README.md and tests/performance/mm-connect/README.md replace clone paths, build commands, GitHub links, and CI env var wording (e.g. RN_PLAYGROUND_APK_VERSION pins a metamask-connect release).

Reviewed by Cursor Bugbot for commit 01b27f1. Bugbot is set up for automated code reviews on this repo. Configure here.

@metamaskbot metamaskbot added the team-wallet-integrations Wallet Integrations team label Apr 16, 2026
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Apr 16, 2026
@ffmcgee725 ffmcgee725 marked this pull request as ready for review April 16, 2026 10:03
@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@ffmcgee725 ffmcgee725 requested a review from a team as a code owner April 29, 2026 14:16

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3055e21. Configure here.

Comment thread tests/performance/mm-connect/utils.ts
@sonarqubecloud

Copy link
Copy Markdown

@cortisiko cortisiko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a cursor bot high sev comment, can you address and then run the mm connect tests? Feel free to ping when you are ready for a review

@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All four changed files are limited to renaming references from connect-monorepo to metamask-connect (a GitHub repository rename/migration):

  1. tests/performance/README.md — Pure documentation: updated repo name in links and text.
  2. tests/performance/mm-connect/README.md — Pure documentation: updated repo name in directory layout examples, commands, and troubleshooting steps.
  3. tests/performance/mm-connect/utils.ts — Only string literals changed: the local fallback APK path (candidate Implement loading spinner during page loads #3, lowest priority, not used in CI) and error message strings. No logic, no control flow, no imports changed.
  4. tests/scripts/fetch-rn-playground-apk.sh — The REPO variable updated from MetaMask/connect-monorepo to MetaMask/metamask-connect. This is a functional rename to point to the correct GitHub repository after a repo migration. It does not affect any MetaMask Mobile app code or Detox E2E test flows.

None of these changes touch any MetaMask Mobile app source code, Detox test specs, page objects, selectors, or shared test infrastructure. No E2E test tags are warranted.

Performance Test Selection:
The changes are limited to renaming connect-monorepo to metamask-connect in documentation, string literals, and a shell script variable. No performance test spec files were modified, no app code was changed, and no performance-sensitive flows were affected. The utils.ts change only updates a local fallback APK path string and error messages — no measurement logic, timing code, or test scenarios were altered. The shell script change updates the GitHub repo target for APK downloads (a repository migration rename), which does not affect any performance test behavior or metrics.

View GitHub Actions results

@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jun 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template risk:low AI analysis: low risk size-S team-wallet-integrations Wallet Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants