chore(runway): cherry-pick refactor: feature flag watchlist cp-7.82.0#31601
Open
runway-github[bot] wants to merge 1 commit into
Open
chore(runway): cherry-pick refactor: feature flag watchlist cp-7.82.0#31601runway-github[bot] wants to merge 1 commit into
runway-github[bot] wants to merge 1 commit into
Conversation
…#31581) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until this PR meets the canonical Definition of Ready For Review in `docs/readme/ready-for-review.md`. In short: the template must be materially complete (not just section titles present), all status checks must be currently passing, and the only expected follow-up commits must be reviewer-driven. --> <!-- mms-check directive vocabulary — read by .github/scripts/shared/pr-template-checks.ts at module load to build the validation plan. Directives are invisible in rendered markdown and must NOT be removed or edited without updating the validator registry. type=text Section must contain non-placeholder prose. type=changelog Section must have a valid CHANGELOG entry: line. type=issue-link Section must have a Fixes:/Closes:/Refs: line with a value. type=manual-testing Section must have real testing steps or an explicit N/A. type=screenshot Section must have evidence (image/URL) or an explicit N/A. type=checklist Section must have all checkboxes consciously checked. required=true|false Whether a missing/invalid section runs the validator at all. blocking=true|false Whether a failure of this check fails the CI workflow. Default: false — failures are shown as warnings in the sticky comment but do not block the PR. Sections without a directive are checked for structural presence only. --> ## **Description** <!-- mms-check: type=text required=true --> Adds feature flag to toggle between v1 and v2 perps watchlist ## **Changelog** <!-- mms-check: type=changelog required=true blocking=true --> <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: feature flag v2 perps watchlist ## **Related issues** <!-- mms-check: type=issue-link required=true --> Fixes: n/a ## **Manual testing steps** <!-- mms-check: type=manual-testing required=true --> ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- mms-check: type=screenshot required=true --> Off: <img width="433" height="874" alt="Screenshot 2026-06-11 at 10 40 17 AM" src="https://github.com/user-attachments/assets/5fd1eb08-77fd-492b-b20a-362da23ba746" /> On: <img width="428" height="876" alt="Screenshot 2026-06-11 at 10 37 08 AM" src="https://github.com/user-attachments/assets/b08bc5e9-224e-4e87-9130-33170a781220" /> ## **Pre-merge author checklist** <!-- mms-check: type=checklist required=true --> <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches multiple Perps home/list surfaces and layout visibility; risk is mitigated by default-off production flag and explicit V1 path, but wrong flag reads could show or hide watchlist UI inconsistently. > > **Overview** > Introduces the remote flag **`perpsWatchlistV2Enabled`** (via **`selectPerpsWatchlistEnabledFlag`**) to roll out the redesigned Perps watchlist behind a version-gated switch, defaulting to the legacy experience when off. > > **`PerpsWatchlistMarkets`** now branches: **V1** hides the section when empty (no suggestions, show-more, or V2 empty UI); **V2** keeps the redesigned behavior. The market list **watchlist filter pill** and **empty-watchlist suggested markets** path are only active when the flag is on. **`PerpsTabView`** only treats suggested markets as making the watchlist “visible” when the flag is on, avoiding wrong Explore header spacing under V1. > > Registry, mocks, component-view presets, and unit tests cover flag on/off for the list view, watchlist component, and selector. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 56b8e9e. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
mm-token-exchange-service
Bot
added
the
team-bots
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
sleepytanya
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds feature flag to toggle between v1 and v2 perps watchlist
Changelog
CHANGELOG entry: feature flag v2 perps watchlist
Related issues
Fixes: n/a
Manual testing steps
Screenshots/Recordings
Off:
On:
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Medium Risk
Touches multiple Perps home/list surfaces and layout visibility; risk
is mitigated by default-off production flag and explicit V1 path, but
wrong flag reads could show or hide watchlist UI inconsistently.
Overview
Introduces the remote flag
perpsWatchlistV2Enabled(viaselectPerpsWatchlistEnabledFlag) to roll out the redesigned Perpswatchlist behind a version-gated switch, defaulting to the legacy
experience when off.
PerpsWatchlistMarketsnow branches: V1 hides the sectionwhen empty (no suggestions, show-more, or V2 empty UI); V2 keeps the
redesigned behavior. The market list watchlist filter pill and
empty-watchlist suggested markets path are only active when the flag
is on.
PerpsTabViewonly treats suggested markets as making thewatchlist “visible” when the flag is on, avoiding wrong Explore header
spacing under V1.
Registry, mocks, component-view presets, and unit tests cover flag
on/off for the list view, watchlist component, and selector.
Reviewed by Cursor Bugbot for commit
56b8e9e. Bugbot is set up for automated
code reviews on this repo. Configure
here.