fix(ci): re-run PR size check on base retarget - #33868
Conversation
… job conditions. The workflow now responds to pull request edits while ensuring it only re-runs for relevant changes to the base branch. Signed-off-by: Nicolas MASSART <nicolas.massart@consensys.net>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0891e2d. Configure here.
A job-level `if` skipping non-base edits still posts a `skipped` check run for the same head SHA, which GitHub treats as authoritative and can silently clear a prior oversized-PR failure. Always recomputing avoids that risk since the diff calculation is cheap. Co-authored-by: Cursor <cursoragent@cursor.com>
The comment explained a job-level if condition that was already removed in a prior commit. Co-authored-by: Cursor <cursoragent@cursor.com>
|




Description
check-pr-max-linescould report a stale/incorrect size label (e.g.size-XL) after a stacked PR was rebased ontomainand its base branch retargeted. The workflow only re-ran onopened | reopened | synchronize, so a base change alone never triggered a fresh check against the new base.This adds
editedto thepull_requesttrigger types, gated so the job only re-runs for base-branch edits (github.event.changes.base != null), not unrelated title/body edits.Related fix in the shared
pr-line-checkaction (resolves the live PR base instead of trusting the webhook payload): MetaMask/github-tools#273Changelog
CHANGELOG entry: null
Related issues
Refs: MCWP-747
Manual testing steps
Screenshots/Recordings
N/A - CI workflow change, no UI impact.
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
N/A - CI workflow-only change, no app runtime impact.
Pre-merge reviewer checklist
Note
Low Risk
CI trigger-only change with no app, auth, or data impact;
editedmay also run the job on title/body edits.Overview
check-pr-max-linesnow listens forpull_requesteditedin addition toopened,reopened, andsynchronize.That lets the shared
pr-line-checkaction run again when a PR is updated without a new push—e.g. after retargeting the base branch following a rebase—so size labels reflect the diff against the current base instead of staying stale.Reviewed by Cursor Bugbot for commit 756f1cf. Bugbot is set up for automated code reviews on this repo. Configure here.