Evaraimundez#823
Open
nepeta70 wants to merge 2 commits intoMewsSystems:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made a very simple implementation, I just separated some concerns like the client where I used a retry strategy to get the endpoint response. In a real production solution I'd also add logging and would use async calls, but I kept it async to not change the interface of the original provider. I left it as the original one like I would do if I had to work with any legacy code where I shouldn't change the interface. But I upgraded the .NET framework to 10 because it's one of the latest and I wanted to show my experience with it. I'd also organize the folder structure in a production solution, but it would be overkill here.