Repository navigation
feat(cli): close the remaining gaps in the CLI command groups - #256
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…onsumes --env-file
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes the gaps left on #228 to #236 after #237, as listed in the comment on each issue. The issues stay open:
Refs, notCloses, because the release (tag, GitHub release, npm publish) and the items that need an API or wording change are not part of this PR.--limit/--page/--all(30 rows, with a stderr note when rows are left out) onproject,server,role,sync logs,webhookanddiscord-webhooklists;-q/--jsonwhere missing; two examples on every command, checked by a test against the real command tree (it caughtschema preview --stepandaudit list --action-type, which do not exist); a getting-started screen when run without arguments;doctor --json; hyphenated aliases andwebhook submissions ofhidden.project create --serverand--scope, and the wizard offers the main server; a test that the key never reaches the config file.sync run --waitprints member deltas and exits6on timeout;server update --type --sync-frequency-hours --permission-policy.member export --search --joined-after(the export endpoint now acceptsjoinedAfter);--roletakes names.@mcid/contractschecked by both the API verifier and the CLI signer;webhook watchdedupe and NDJSON tests.audit exporttakes the same filters asaudit list.dev ssooffers to add a missing redirect URI and keeps the stored ones; tests for the key lookup order.Not done on purpose:
project key show --reveal(the API returns only the prefix),role inheritance set <from> <to>(the DTO has no target role),settings reset <key>(the endpoint takes no body),monitor usage --period 24h(the API accepts7d|30d|90d). These are wording fixes for the issues.How it was checked
tsc,eslint, coverage gate (src/commands/**at 46/37/43/47); the built bundle starts (node apps/cli/bin/mcid-cli.js) and prints the getting-started screen.tsc -p tsconfig.build.json,eslint.@mcid/form-schema: 176 tests. Web: 1383 tests including the docs suites, typecheck.pnpm docs:apiandpnpm --filter mcid-cli generate:api-typeswere run and committed.build, and the commands against a live MCID (the tests use the fake MCID server).Checklist
pnpm lint,pnpm typecheck,pnpm testpass (pnpm buildran for the CLI bundle only)pnpm docs:apiand committed the result (CI checks this)Refs #228
Refs #229
Refs #230
Refs #231
Refs #232
Refs #233
Refs #234
Refs #235
Refs #236