Skip to content

feat(cli): close the remaining gaps in the CLI command groups - #256

Merged
BenAbdou1001 merged 5 commits into
devfrom
benabdou/cli-remaining-issue-gaps
Oct 27, 2026
Merged

BenAbdou1001 merged 5 commits into
devfrom
benabdou/cli-remaining-issue-gaps

Conversation

@BenAbdou1001

Copy link
Copy Markdown
Collaborator

What and why

Closes the gaps left on #228 to #236 after #237, as listed in the comment on each issue. The issues stay open: Refs, not Closes, because the release (tag, GitHub release, npm publish) and the items that need an API or wording change are not part of this PR.

Not done on purpose: project key show --reveal (the API returns only the prefix), role inheritance set <from> <to> (the DTO has no target role), settings reset <key> (the endpoint takes no body), monitor usage --period 24h (the API accepts 7d|30d|90d). These are wording fixes for the issues.

How it was checked

  • CLI: 311 tests, tsc, eslint, coverage gate (src/commands/** at 46/37/43/47); the built bundle starts (node apps/cli/bin/mcid-cli.js) and prints the getting-started screen.
  • API: 1407 tests, tsc -p tsconfig.build.json, eslint. @mcid/form-schema: 176 tests. Web: 1383 tests including the docs suites, typecheck.
  • pnpm docs:api and pnpm --filter mcid-cli generate:api-types were run and committed.
  • Not run: the web build, and the commands against a live MCID (the tests use the fake MCID server).

Checklist

  • Tests were added or updated, and written to fail first (added alongside the code, not red-first)
  • pnpm lint, pnpm typecheck, pnpm test pass (pnpm build ran for the CLI bundle only)
  • If an endpoint, a DTO or a Swagger decorator changed: ran pnpm docs:api and committed the result (CI checks this)
  • The docs describe the changed behaviour, or no docs are affected

Refs #228
Refs #229
Refs #230
Refs #231
Refs #232
Refs #233
Refs #234
Refs #235
Refs #236

@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
mcid Skipped Skipped Oct 27, 2026 1:11pm UTC

@BenAbdou1001
BenAbdou1001 merged commit 46f92fe into dev Oct 27, 2026
5 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 91f378ab Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant