Skip to content

feat: navigate between applications, add a 2nd review tab and list the oldest first - #83

Merged
Adel2411 merged 6 commits into
devfrom
feat/hr-review-navigation
Nov 6, 2026
Merged

Adel2411 merged 6 commits into
devfrom
feat/hr-review-navigation

Conversation

@0xHouss

@0xHouss 0xHouss commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator

Three HR review improvements, plus local test accounts to try them.

  • Arrows between applications: the registration page shows ‹ 12 of 87 › next to the back link, and ← / → do the same. They follow the list the registration was opened from (registrations: search, status tab, sort; recommendations: filters, sort), across pages. The keys are ignored while typing, in a dialog or menu, or with a modifier held (Alt+← stays browser back); the end arrows are disabled, no wrap-around. An application that left the list (e.g. reviewed out of 2nd Review) keeps arrows to its neighbors and shows only the total ("86 in this list"). The back link returns to the list page of the application on screen. The neighbors come from the whole list's ids and names (registrationListOrder, recommendationListOrder), ~5 ms at 500 registrations; list-navigation.ts notes the keyset version for when it gets bigger.
  • 2nd Review tab: between Pending and Interview, the pending applications with exactly one reviewer. A filter, not a status: they stay Pending (badge and Pending tab) and no data changes. It is computed in the query (ONE_REVIEWER_FILTER next to currentReviews in timeline.ts, same rule: latest review per person, unless back to pending). Checked against currentReviews on hand-made timelines (including a review set back to pending) and on the seeded registrations.
  • Oldest first: the registrations and recommendations lists default to the oldest submissions first; clicking Submitted still flips them.
  • pnpm db:seed-staff: local test accounts president@seed.test, hr1@seed.test, hr2@seed.test (password microclub-dev, no forced change), recreated on each run, refused on a non-local MONGODB_URI. Its localhost guard is now shared with db:seed-registrations.

Tested in the browser with the seeded accounts: arrows, keyboard, tooltips, 2nd Review tab and counts, oldest-first order. Lint, typecheck and tests pass on each commit.

Closes #80
Closes #81
Closes #82

@vercel

vercel Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mc-website Ready Ready Preview Nov 6, 2026 11:27am UTC

@Adel2411
Adel2411 merged commit d5d2abd into dev Nov 6, 2026
3 checks passed
@Adel2411
Adel2411 deleted the feat/hr-review-navigation branch November 6, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants