Repository navigation
feat: navigate between applications, add a 2nd review tab and list the oldest first - #83
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was
linked to
issues
Nov 6, 2026
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three HR review improvements, plus local test accounts to try them.
‹ 12 of 87 ›next to the back link, and ← / → do the same. They follow the list the registration was opened from (registrations: search, status tab, sort; recommendations: filters, sort), across pages. The keys are ignored while typing, in a dialog or menu, or with a modifier held (Alt+← stays browser back); the end arrows are disabled, no wrap-around. An application that left the list (e.g. reviewed out of 2nd Review) keeps arrows to its neighbors and shows only the total ("86 in this list"). The back link returns to the list page of the application on screen. The neighbors come from the whole list's ids and names (registrationListOrder,recommendationListOrder), ~5 ms at 500 registrations;list-navigation.tsnotes the keyset version for when it gets bigger.ONE_REVIEWER_FILTERnext tocurrentReviewsintimeline.ts, same rule: latest review per person, unless back to pending). Checked againstcurrentReviewson hand-made timelines (including a review set back to pending) and on the seeded registrations.pnpm db:seed-staff: local test accountspresident@seed.test,hr1@seed.test,hr2@seed.test(passwordmicroclub-dev, no forced change), recreated on each run, refused on a non-localMONGODB_URI. Its localhost guard is now shared withdb:seed-registrations.Tested in the browser with the seeded accounts: arrows, keyboard, tooltips, 2nd Review tab and counts, oldest-first order. Lint, typecheck and tests pass on each commit.
Closes #80
Closes #81
Closes #82