This repository was archived by the owner on Oct 14, 2020. It is now read-only.
Add a very hacky version of dockerizerJVM property #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…refactored master)
Contributor
|
Not sure what exactly the Why do you think this a hacky implementation? What would be a better alternative? Also, can this be rebased on top of the latest master, and be updated for boost-gradle? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For initial review. I want to propose another property. This does not need to be merged in right away.
I am looking for some thoughts on this. I would prefer to not combine the 'style' property with the 'jvm' property, but that could be done.