Skip to content

Revert "Set default value of ControlNetUnit.enabled to True (#2912)" #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Norrisengliod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert "Set default value of ControlNetUnit.enabled to True (#2912)" #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal_controlnet/args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class Config:
loopback: bool = False

# General fields.
enabled: bool = True
enabled: bool = False
module: str = "none"

@validator("module", always=True, pre=True)
Expand Down
2 changes: 1 addition & 1 deletion scripts/controlnet_ui/controlnet_ui_group.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ def render(self, tabname: str, elem_id_tabname: str) -> None:
self.pulid_mode,
)

unit = gr.State(ControlNetUnit(enabled=False))
unit = gr.State(ControlNetUnit())

# It is necessary to update unit state actively to avoid potential
# flaky racing issue.
Expand Down
1 change: 0 additions & 1 deletion tests/web_api/detect_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ def test_inpaint_mask(module: str):

@disable_in_cq
@pytest.mark.parametrize("img_index", [i for i, _ in enumerate(portrait_imgs)])
@pytest.mark.skip(reason="test is for SDXL only")
def test_pulid(img_index: int):
"""PuLID preprocessor should not memory leak."""
payload = dict(
Expand Down
1 change: 0 additions & 1 deletion tests/web_api/generation_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ def test_ip_adapter_auto():

@disable_in_cq
@pytest.mark.parametrize("img_index", [i for i, _ in enumerate(portrait_imgs)])
@pytest.mark.skip(reason="test is for SDXL only")
def test_pulid(img_index: int):
"""PuLID should not memory leak."""
assert APITestTemplate(
Expand Down