fix(minimax-docx): support .NET 8 project restore - #109
Open
heliusjing wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MiniMaxAIDocx.Cli.csprojexplicitly in the Bash and PowerShell setup paths.env_check.shprint the real restore/build error and an exact retry command instead of hiding all output.Why
On a clean checkout with .NET SDK 8.0.125 / MSBuild 17.8, restoring the
scripts/dotnetdirectory selectsMiniMaxAIDocx.slnxand fails with:The existing environment check suppresses that error and reports a generic NuGet failure even when
nuget.org, TLS, and the required packages are available. Restoring the CLI.csprojdirectly restores both referenced projects and works on the declared .NET 8 minimum.Related to #24. This is intentionally a smaller alternative scoped only to the
.slnx/ .NET 8 compatibility bug and actionable diagnostics; it does not add offline-feed behavior.Verification
bash -n skills/minimax-docx/scripts/env_check.sh skills/minimax-docx/scripts/setup.shbash skills/minimax-docx/scripts/env_check.shon .NET SDK 8.0.125:Status: READYbash skills/minimax-docx/scripts/setup.sh --minimal --skip-verifybash skills/minimax-docx/scripts/setup.sh --minimal: builds successfully and creates the verification DOCXpython3 .claude/skills/pr-review/scripts/validate_skills.py --path skills/minimax-docx: passThe repository-wide validator still fails on the pre-existing
skills/minimax-multimodal-toolkitname mismatch (mmx-clivs. directory name);minimax-docxpasses.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.