Regenerate the MeosOps facades and provision MEOS SRID data - #19
Merged
estebanzimanyi merged 2 commits intoJul 10, 2026
Merged
Conversation
The committed MeosOps* facades were generated against an older JMEOS and no
longer compile against MobilityDB/JMEOS main: the *_as_hexwkb functions folded
their trailing out-parameter (required (Pointer,byte), the facades called
(Pointer,byte,Pointer)) and an int widened to long, giving 12 compilation
errors in MeosOpsFree{Pose,Npoint,Cbuffer}, MeosOps{STBox,TBox,Set,Span,SpanSet}.
Regenerate the 8 drifted facades with tools/codegen_facades.py against a jar
built from JMEOS main. Verified with a clean build (mvn clean test) against the
freshly built libmeos + jar: 11 tests, 0 failures, 0 errors.
The native build target does not install MEOS's data files. libmeos reads spatial_ref_sys.csv from a fixed default path (/usr/local/share) to resolve SRIDs; when the file is absent it prints "Cannot open the spatial_ref_sys.csv file" to stdout. Inside a surefire fork that raw native write corrupts the fork's encoded channel, so any SRID-touching test (npoint, tgeompoint) aborts the JVM with "The forked VM terminated without properly saying goodbye" even though the test logic is correct. Stage spatial_ref_sys.csv and ways1000.csv into /usr/local/share after the build so SRID resolution succeeds and nothing is written to the fork channel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generated
MeosOps*facades match the current JMEOS FFI surface.build-jmeos.shstages MEOS's SRID and network reference data (spatial_ref_sys.csv,ways1000.csv) into/usr/local/share, where libmeos reads it to resolve SRIDs at runtime, so SRID-dependent operations (npoint, tgeompoint) run under the surefire test JVM.