Uniformize the JMEOS build with MobilitySpark and MobilityFlink - #26
Merged
estebanzimanyi merged 1 commit intoJul 28, 2026
Merged
Conversation
MobilityKafka built the JMEOS jar through its own build-jmeos.sh and depended on it as com.mobilitydb:jmeos:1.4.0, while MobilitySpark and MobilityFlink build JMEOS main directly and install the jar as org.jmeos:meos:1.0. Adopt the same build and coordinates: CI checks out JMEOS, builds it against the provisioned catalog and libmeos, and installs jar/JMEOS.jar as org.jmeos:meos:1.0; the binding depends on those coordinates; the tests load libmeos from /usr/local/lib where provision-meos installs it. build-jmeos.sh is removed; GENERATION.md, README and the benchmark doc describe the shared build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
MobilityKafka builds the JMEOS jar and consumes it the same way MobilitySpark and MobilityFlink do.
Why
Spark and Flink both check out JMEOS
main, build it against the provisioned catalog + libmeos, and installjar/JMEOS.jarasorg.jmeos:meos:1.0. Kafka instead built the jar through its ownbuild-jmeos.shand depended on it ascom.mobilitydb:jmeos:1.4.0— the last divergence in how the three JVM consumers build JMEOS.Changes
.github/workflows/maven.yml— checks out JMEOS, builds it against the provisioned catalog + libmeos, and installsjar/JMEOS.jarasorg.jmeos:meos:1.0(verbatim the Spark/Flink step); the tests load libmeos from/usr/local/lib.pom.xml/binding/pom.xml— the binding depends onorg.jmeos:meos:1.0;meos.lib.diris/usr/local/lib(whereprovision-meosinstalls libmeos), which the surefire config exposes asLD_LIBRARY_PATH.build-jmeos.shis removed — the shared build replaces it.GENERATION.md,README.md, and the benchmark doc describe the shared build.Uniformity
After this, all three JVM consumers build JMEOS identically — check out JMEOS
main, build against the provisioned catalog, installorg.jmeos:meos:1.0— differing only in their own facade projection (codegen_jvm.py --engine spark|flink|kafka).