Bugfix: Fix MCP integration by ignoring proxy environment variables#3014
Open
xuyaqist wants to merge 1 commit into
Open
Bugfix: Fix MCP integration by ignoring proxy environment variables#3014xuyaqist wants to merge 1 commit into
xuyaqist wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix MCP connectivity issues caused by proxy environment variables by ensuring MCP HTTP(S) requests do not inherit proxy settings from the runtime environment.
Changes:
- Added a shared
httpx.AsyncClientfactory withtrust_env=Falsefor MCP transports. - Wired the factory into FastMCP
SSETransportandStreamableHttpTransportusage in both tool configuration and remote MCP health checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| backend/services/tool_configuration_service.py | Injects a custom httpx_client_factory into MCP transports created for tool discovery/execution. |
| backend/services/remote_mcp_service.py | Adds create_httpx_client and uses it in MCP health-check transport construction. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| timeout=timeout, | ||
| auth=auth, | ||
| trust_env=False, | ||
| verify=False, |
Comment on lines
+33
to
+37
| return AsyncClient( | ||
| headers=headers, | ||
| timeout=timeout, | ||
| auth=auth, | ||
| trust_env=False, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix: Fix MCP integration by ignoring proxy environment variables