Josh heartbeat monitor re-write #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a bit of a dive into QoS stuff after my googling last night and the heartbeat functionality is sort of in-built in to the QoS profiles - it's hard to understand at first so maybe not the best for readability but wanted to have a go at doing it to try and fully understand how they work!
It somewhat raises the question of if we need a global heartbeat signal that does rover wide disabling or if each critical node should just have liveliness and deadline QoS parameters that can be watched and if either occurs then it does its own connection lost stuff. Both are viable just more of a design methodology and where we think the management of the connection issues should be :)