feat: add You.com plugin marketplace entry#2093
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 00c7ee4eef
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "description": "You.com skills for search, contents, research, finance, and integration discovery.", | ||
| "homepage": "https://docs.you.com", | ||
| "keywords": ["you.com", "mcp", "web-search", "research", "finance", "ard"], | ||
| "source": "https://github.com/youdotcom-oss/agent-skills" |
There was a problem hiding this comment.
For this bare GitHub source, Kimi's installer resolves https://github.com/{owner}/{repo} by following /releases/latest before falling back to HEAD (packages/agent-core/src/plugin/github-resolver.ts), so selecting this row currently downloads the youdotcom@1.0.6 release archive, not main; that tag's root does not include .kimi-plugin/kimi.plugin.json (https://github.com/youdotcom-oss/agent-skills/tree/youdotcom%401.0.6), so install fails at manifest detection instead of installing the plugin. Pin the source to a ref that contains the Kimi manifest, e.g. /tree/main.
Useful? React with 👍 / 👎.
| "source": "https://github.com/vercel/vercel-plugin" | ||
| }, | ||
| { | ||
| "id": "you-com", |
There was a problem hiding this comment.
The You.com Kimi manifest declares name: "you" (https://raw.githubusercontent.com/youdotcom-oss/agent-skills/main/.kimi-plugin/plugin.json), and PluginManager.install() stores installed records under normalizePluginId(parsed.manifest.name); meanwhile the marketplace UI checks installed/update state by comparing entry.id with installed plugin ids. With id: "you-com", after a successful install it continues to show this marketplace row as installable and never offers future update badges for the installed you plugin; use id: "you" or update matching logic.
Useful? React with 👍 / 👎.
Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
00c7ee4 to
d6e09a9
Compare
|
Addressed the review feedback:
Validation rerun:
|
1 participant
Summary
Validation