Fix: Show placeholder icon when item has no thumbnail#44
Open
hyldmh wants to merge 1 commit into
Open
Conversation
When an item has no thumbnail, the previous code returned an empty View — invisible with a transparent background. Now it shows a MaterialIcons broken-image placeholder icon.
Mossop
requested changes
May 18, 2026
Owner
Mossop
left a comment
There was a problem hiding this comment.
Thanks but this makes a change to the wrong package. packages/cli/resources/thumbnail.js is probably where the issue is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Shows with no thumbnail appear as broken images
Closes #43
Problem: When an item has no thumbnail, the code returned an empty
<View style={style} />— a transparent, invisible box. Users see this as a "broken image".Fix: When
uriis undefined (no thumbnail stored), render abroken-imageMaterialIcons placeholder instead of an empty View.