Repository navigation
fix: order secondary tables by their level order - #2
Merged
Merged
Conversation
Tables named by levels used to appear in the order MultiQC ran the modules that first fed them, which put a one-row cohort table above the library table. They now follow the order of the levels in the config, and a table that received no rows is left out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tables named by
levels[].tablecame back in the order MultiQC happened to run the modules that first fed them, so in a real report a one-row cohort annotation table sat above the library table even though its level was listed last.pivot()now seeds the tables from the levels in config order and drops the ones that received no rows;tests/test_pivot.py::test_tables_follow_level_order_not_module_ordercovers it with a snpEff-style section running ahead of a FastQC-style one. Version bumped to 0.1.1.