Repository navigation
feat: let a labelled level drop its rows from General Statistics - #3
Merged
Merged
Conversation
A labelled level now takes `keep_rows`, which defaults to true. With `keep_rows: false` its columns still fold onto the group row, renamed, placed and titled as before, but the original rows are no longer kept beneath it. Setting it to false on a level without a label, or on a level with a table, is a validation error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets a labelled level fold its columns onto the group row without keeping its rows beneath it in General Statistics.
What changes
Levelgainskeep_rows(defaulttrue, so existing configs render as before).keep_rows: false, a labelled level's columns still fold onto the group row under their labelled titles, but the rows themselves leave General Statistics. Module sections are untouched, so the rows still appear there.keep_rows: falseon a level without alabel, or with atable, fails validation: those levels already remove or move their rows.Example
Tested
UV_NO_CONFIG=1 UV_PYTHON=3.12 uv run --locked poe check-all: format, lint, mypy and basedpyright clean; 31 tests pass at 100% coverage.keep_rows: falseon one labelled level removed its 24 rows from General Statistics while its module section still listed them.