Skip to content

Conversation

@neheb
Copy link
Contributor

@neheb neheb commented Nov 18, 2024

Related: mesonbuild/wrapdb#1345

I don't know if it's enough to fix.

headers already define it. also causes compilation issue on 32-bit.

Signed-off-by: Rosen Penev <[email protected]>
@MaxKellermann
Copy link
Member

I don't understand the third patch. The commit message says "use ld for function definitions even on non Linux / GCC is available on MinGW" but the diff is neither about ld nor about gcc.

@neheb
Copy link
Contributor Author

neheb commented Nov 18, 2024

The file is named .ld

@MaxKellermann
Copy link
Member

I still don't get it. And I've grown wary of merging your low-effort stuff. Too often did you submit code changes to me that even you didn't understand. I only merge anything from you with a proper commit message that explains every detail.

@neheb
Copy link
Contributor Author

neheb commented Nov 18, 2024

I'll remove it. It's not important anyway.

@MaxKellermann
Copy link
Member

"meson: add def file"
Bad commit message. I have no idea what this is about.
Oh please. I just wrote I want proper commit messages, and now you submit another commit with a bad commit message.

A def file is needed on MSVC in lieu of dllexport/dllimport declarations
in the code. Should have the same symbols as libmpdclient.ld.

Signed-off-by: Rosen Penev <[email protected]>
@MaxKellermann
Copy link
Member

Why did you remove link_depends?
And who is going to maintain this new def file?

@MaxKellermann
Copy link
Member

No reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants