You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It might be possible to break this down into seperate PR, but I can't think how - everything is interdependent.
Perhaps an initial change would be to have setSelector() (and the constructor) throw an exception if the selector is invalid, using the existing isValid() method. I wouldn't consider this to be a breaking change, more of a fix, though something that would probably go in the 'Changed' section of the changelog.
Perhaps an initial change would be to have setSelector() (and the constructor) throw an exception if the selector is invalid, using the existing isValid() method. I wouldn't consider this to be a breaking change, more of a fix, though something that would probably go in the 'Changed' section of the changelog.
#1498 covers exceptions possibly being thrown by setSelector() and the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enhancementrefactorFor PRs that refactor code without changing functionality
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1325.