Skip to content

[FEATURE] Represent Selector as Component objects#1496

Draft
JakeQZ wants to merge 1 commit intomainfrom
feature/selector-representation
Draft

[FEATURE] Represent Selector as Component objects#1496
JakeQZ wants to merge 1 commit intomainfrom
feature/selector-representation

Conversation

@JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Feb 5, 2026

Part of #1325.

@JakeQZ JakeQZ self-assigned this Feb 5, 2026
@JakeQZ JakeQZ added enhancement refactor For PRs that refactor code without changing functionality labels Feb 5, 2026
@JakeQZ JakeQZ marked this pull request as draft February 5, 2026 20:11
@coveralls
Copy link

coveralls commented Feb 5, 2026

Coverage Status

coverage: 72.749% (+0.1%) from 72.601%
when pulling 9927247 on feature/selector-representation
into 600d163 on main.

@JakeQZ JakeQZ force-pushed the feature/selector-representation branch 4 times, most recently from 4a4d0f0 to 0effcdb Compare February 5, 2026 23:44
@JakeQZ JakeQZ marked this pull request as ready for review February 5, 2026 23:55
@JakeQZ JakeQZ requested a review from oliverklee February 5, 2026 23:55
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Feb 5, 2026

Would like initial feedback on this...

There's a bit more to do:

  • A few more tests;
  • Changelog entries.

It might be possible to break this down into seperate PR, but I can't think how - everything is interdependent.

@JakeQZ JakeQZ requested a review from sabberworm February 5, 2026 23:58
@JakeQZ JakeQZ force-pushed the feature/selector-representation branch from 0effcdb to 9927247 Compare February 6, 2026 00:00
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Feb 6, 2026

It might be possible to break this down into seperate PR, but I can't think how - everything is interdependent.

Perhaps an initial change would be to have setSelector() (and the constructor) throw an exception if the selector is invalid, using the existing isValid() method. I wouldn't consider this to be a breaking change, more of a fix, though something that would probably go in the 'Changed' section of the changelog.

@JakeQZ JakeQZ marked this pull request as draft February 6, 2026 01:26
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Feb 6, 2026

Perhaps an initial change would be to have setSelector() (and the constructor) throw an exception if the selector is invalid, using the existing isValid() method. I wouldn't consider this to be a breaking change, more of a fix, though something that would probably go in the 'Changed' section of the changelog.

#1498 covers exceptions possibly being thrown by setSelector() and the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement refactor For PRs that refactor code without changing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants