Fix comments being omitted in the middle of a rule#339
Open
fabianderschatta wants to merge 1 commit intoMyIntervals:mainfrom
Open
Fix comments being omitted in the middle of a rule#339fabianderschatta wants to merge 1 commit intoMyIntervals:mainfrom
fabianderschatta wants to merge 1 commit intoMyIntervals:mainfrom
Conversation
fabianderschatta
force-pushed
the
comment-fix
branch
from
44c3a55 to
987077b
Compare
Contributor
|
This test now passes without any changes to the code on |
Collaborator
Thanks for checking up on this. I recall a few issues with comment parsing being fixed, but don't know their issue/PR numbers offhand. Rather than closing this immediately, I'd prefer to verify that the issue is ckecked with unit tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #180
We do rely on this patch, it would be great if it could be merged into the main repository.