Open
Conversation
JakeQZ
requested changes
Jul 10, 2024
Collaborator
JakeQZ
left a comment
JakeQZ
left a comment
There was a problem hiding this comment.
Thanks for this. The changes look fine. However the test case SizeTest should be extended to cover the units now supported. Also, could you add an entry to CHANGELOG.md (newest first)? I've also made a suggestion to make a DocBlock comment more maintainable.
| { | ||
| /** | ||
| * vh/vw/vm(ax)/vmin/rem are absolute insofar as they don’t scale to the immediate parent (only the viewport) | ||
| * vh/vw/vm(ax)/vmin/rem/svh/lvh/dvh/svw/lvw/dvw are absolute insofar as they don’t scale to the immediate parent (only the viewport) |
Collaborator
There was a problem hiding this comment.
Rather than having to maintain the llist of units in the comment, it might be better to make the comment generic.
Suggested change
| * vh/vw/vm(ax)/vmin/rem/svh/lvh/dvh/svw/lvw/dvw are absolute insofar as they don’t scale to the immediate parent (only the viewport) | |
| * These are absolute insofar as they don’t scale to the immediate parent (only the viewport). |
JakeQZ
added this to the
9.0.0: Drop support for PHP < 7.2 and clean up things milestone
oliverklee
modified the milestones:
9.1.0: Add support for PHP 8.5,
9.2.0: New features, bug fixes and deprecations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more size units to be correctly recognized by the parser.