Skip to content

[fix] client sdk type and req in aggregator and key server#430

Merged
joyqvq merged 4 commits into
mainfrom
joy/client-type-fi
Apr 30, 2026
Merged

[fix] client sdk type and req in aggregator and key server#430
joyqvq merged 4 commits into
mainfrom
joy/client-type-fi

Conversation

@joyqvq

@joyqvq joyqvq commented Jan 15, 2026

Copy link
Copy Markdown
Collaborator

Description

follow up for #422 (comment)

aggregator, if a request is received with:

  • "aggregator" sdk type: error
  • "typescript" sdk type: check its req in config
  • "rust" sdk type: check its req in config
  • missing or unknown Client-Sdk-Type: error
  • missing or unnownClient-Sdk-Version: error

key server, if a request is received with:

  • "aggregator" sdk type: check its req in config
  • "typescript" sdk type: check its req in config
  • "rust" sdk type: check its req in config
  • missing or unknown Client-Sdk-Type: only then if Client-Sdk-Version is present and valid
  • missing Client-Sdk-Version: error

Test plan

updated tests

Comment thread crates/key-server/src/server.rs
@joyqvq joyqvq force-pushed the joy/client-type-fi branch from 74c0a9f to 269ca0e Compare January 21, 2026 16:08
@joyqvq joyqvq force-pushed the joy/client-type-fi branch 2 times, most recently from 31c2d75 to 73c1436 Compare April 27, 2026 15:29
@joyqvq joyqvq requested a review from benr-ml April 27, 2026 15:29
@joyqvq joyqvq force-pushed the joy/client-type-fi branch from 73c1436 to d60d25b Compare April 27, 2026 15:44
@joyqvq joyqvq requested a review from abhinavg6 as a code owner April 27, 2026 15:44
@joyqvq joyqvq enabled auto-merge (squash) April 27, 2026 19:04
@joyqvq joyqvq force-pushed the joy/client-type-fi branch from 6904884 to db4e068 Compare April 30, 2026 19:13
@joyqvq joyqvq force-pushed the joy/client-type-fi branch from db4e068 to 81dce78 Compare April 30, 2026 20:17
@joyqvq joyqvq force-pushed the joy/client-type-fi branch from 8bcdf5c to fed7476 Compare April 30, 2026 21:21
@joyqvq joyqvq merged commit 322df90 into main Apr 30, 2026
14 of 17 checks passed
@joyqvq joyqvq deleted the joy/client-type-fi branch April 30, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants