Skip to content

Conversation

@mkelley
Copy link
Member

@mkelley mkelley commented Dec 23, 2025

Why did this become a problem now? 🤷🏻 But LinearPhaseFunc's empty defaults causes the documentation build to crash with the latest Sphinx.

While I'm here, I'll also add some doc substitutions used in astropy for (a) consistency, and (b) so that sbpy's ArbitraryFrame can inherit astropy docstrings.

@github-actions
Copy link

Thank you for your contribution to sbpy, an Astropy affiliated package! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the sbpy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label.
  • Is a milestone added?

@mkelley
Copy link
Member Author

mkelley commented Dec 23, 2025

@hhsieh00 Can you review / approve ignoring the MacOS failure? I will address this in #427

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.72%. Comparing base (843b1a2) to head (cc363b7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          92       92           
  Lines        8459     8459           
=======================================
  Hits         7167     7167           
  Misses       1292     1292           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@hhsieh00 hhsieh00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mkelley mkelley merged commit 162139f into NASA-Planetary-Science:main Dec 23, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants