Skip to content

Conversation

@DWolfsNHS
Copy link
Collaborator

Description

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • Exceptions/Exclusions to coding standards (e.g. #noqa or #NOSONAR) are included within this Pull Request.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

- Create GPProviderClient class to interact with GPProvider FHIR API
- Add initialization method with provider and consumer ASIDs
- Implement get_structured_record method to fetch patient records
- Update unit tests to verify successful response from GPProviderClient from example.com
- Change return type of get_structured_record method to Response
- Update timeout parameter to None for quicker development
- Add mock_request_get fixture to unit tests for simulating API responses
- Rename method `get_structured_record` to `access_structured_record`
- Change HTTP method from GET to POST for fetching structured patient records
- Update request headers to match GP Connect specifications
- Enhance mock request handling in tests for POST requests
- Add a GPProviderStub class to simulate structured patient record responses
- Correct header casing in GPProviderClient for FHIR API requests
- Enhance GPProviderStub to return a Response object
- Refactor mock_request_post to utilize GPProviderStub
@sonarqubecloud
Copy link

@DWolfsNHS DWolfsNHS closed this Jan 15, 2026
@DWolfsNHS DWolfsNHS deleted the feature/GPCAPIM-251_Retrieve_patient_from_Provider branch January 15, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant